keith-turner commented on code in PR #3591:
URL: https://github.com/apache/accumulo/pull/3591#discussion_r1263103743
##########
assemble/bin/accumulo-cluster:
##########
@@ -67,15 +67,17 @@ function parse_config {
exit 1
fi
- if [[ -z $TSERVER_HOSTS ]]; then
- echo "ERROR: tservers not found in ${conf}/cluster.yaml"
- exit 1
- fi
-
- for queue in $COMPACTION_QUEUES; do
- Q="COMPACTOR_HOSTS_${queue}"
+ for group in $COMPACTOR_GROUPS; do
+ Q="COMPACTOR_HOSTS_${group}"
if [[ -z ${!Q} ]]; then
- echo "WARN: External compaction queue $queue configured, but no
compactors configured for it"
+ echo "WARN: External compaction group $group configured, but no
compactors configured for it"
+ fi
+ done
+
+ for group in $TSERVER_GROUPS; do
Review Comment:
What will happen in the case where they are zero tserver groups. Not an
empty group, but no `tserver:` section in the yaml file?
##########
core/src/main/thrift/tabletserver.thrift:
##########
@@ -122,8 +122,8 @@ enum TCompactionKind {
USER
}
-struct TCompactionQueueSummary {
- 1:string queue
+struct TCompactionGroupSummary {
Review Comment:
A lot of the code in the tserver compaction code this PR is modifying was
deleted in #3604.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
