keith-turner commented on code in PR #3591:
URL: https://github.com/apache/accumulo/pull/3591#discussion_r1264251754
##########
assemble/bin/accumulo-cluster:
##########
@@ -67,15 +67,17 @@ function parse_config {
exit 1
fi
- if [[ -z $TSERVER_HOSTS ]]; then
- echo "ERROR: tservers not found in ${conf}/cluster.yaml"
- exit 1
- fi
-
- for queue in $COMPACTION_QUEUES; do
- Q="COMPACTOR_HOSTS_${queue}"
+ for group in $COMPACTOR_GROUPS; do
+ Q="COMPACTOR_HOSTS_${group}"
if [[ -z ${!Q} ]]; then
- echo "WARN: External compaction queue $queue configured, but no
compactors configured for it"
+ echo "WARN: External compaction group $group configured, but no
compactors configured for it"
+ fi
+ done
+
+ for group in $TSERVER_GROUPS; do
Review Comment:
> Unless we hardcode the group for those tables, it would require checking
the config to get the group and then ensuring that at least
We could make the validation a more lax than that and still have something
useful. Could validate that a non empty group of tablet servers exists and a
non empty group of compactors exists, without worrying about if the group names
or correct. Then could have a generic message like "There are no tablet
servers configured to start, Accumulo requires tablets severs".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
