dlmarion commented on code in PR #3591:
URL: https://github.com/apache/accumulo/pull/3591#discussion_r1263672139
##########
assemble/bin/accumulo-cluster:
##########
@@ -67,15 +67,17 @@ function parse_config {
exit 1
fi
- if [[ -z $TSERVER_HOSTS ]]; then
- echo "ERROR: tservers not found in ${conf}/cluster.yaml"
- exit 1
- fi
-
- for queue in $COMPACTION_QUEUES; do
- Q="COMPACTOR_HOSTS_${queue}"
+ for group in $COMPACTOR_GROUPS; do
+ Q="COMPACTOR_HOSTS_${group}"
if [[ -z ${!Q} ]]; then
- echo "WARN: External compaction queue $queue configured, but no
compactors configured for it"
+ echo "WARN: External compaction group $group configured, but no
compactors configured for it"
+ fi
+ done
+
+ for group in $TSERVER_GROUPS; do
Review Comment:
It will likely succeed and start everything else, but the root and metadata
tables won't be hosted. 1 TabletServer to host the root and metadata tables
should be required. Unless we hardcode the group for those tables, it would
require checking the config to get the group and then ensuring that at least 1
TabletServer is defined for that group. Ideally 1 Compactor should be required
also so that compactions on the root and metadata tables occur. This was the
reason for this
[comment](https://github.com/apache/accumulo/issues/3546#issuecomment-1629616298).
I think that `cluster.yaml` should look like:
```
manager:
- localhost
monitor:
- localhost
gc:
- localhost
tserver:
system:
- localhost
default:
- localhost
compactor:
system:
- localhost
default:
- localhost
sserver:
default:
- localhost
```
Not sure if you want to have that discussion here or in #3546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
