DomGarguilo commented on code in PR #398:
URL: https://github.com/apache/accumulo-website/pull/398#discussion_r1312980153
##########
pages/contact-us.md:
##########
@@ -45,10 +45,10 @@ follow discussions as they happen.
{: .table }
| Name | Description | Read
| Follow | Post |
|-------------------|--------------------------------------------------|------|--------|------|
-| **user** | General user questions, help, and announcements |
[<span class="glyphicon glyphicon-search"/> Archive][U_A] | [<span
class="glyphicon glyphicon-plus"/> Subscribe][U_SU] [<span class="glyphicon
glyphicon-remove"/> Unsubscribe][U_UN] | [<span class="glyphicon
glyphicon-envelope"/> Post][U_P] |
-| **dev** | Contributor discussions and development activity |
[<span class="glyphicon glyphicon-search"/> Archive][D_A] | [<span
class="glyphicon glyphicon-plus"/> Subscribe][D_SU] [<span class="glyphicon
glyphicon-remove"/> Unsubscribe][D_UN] | [<span class="glyphicon
glyphicon-envelope"/> Post][D_P] |
-| **commits** | Code changes |
[<span class="glyphicon glyphicon-search"/> Archive][C_A] | [<span
class="glyphicon glyphicon-plus"/> Subscribe][C_SU] [<span class="glyphicon
glyphicon-remove"/> Unsubscribe][C_UN] | |
-| **notifications** | Automated notifications (GitHub, etc.) |
[<span class="glyphicon glyphicon-search"/> Archive][N_A] | [<span
class="glyphicon glyphicon-plus"/> Subscribe][N_SU] [<span class="glyphicon
glyphicon-remove"/> Unsubscribe][N_UN] | |
+| **user** | General user questions, help, and announcements | [<i
class="fa-solid fa-magnifying-glass"></i> Archive][U_A] | [<i class="fa-solid
fa-plus"></i> Subscribe][U_SU] [<i class="fa-solid fa-xmark"></i>
Unsubscribe][U_UN] | [<i class="fa-solid fa-envelope"></i> Post][U_P] |
Review Comment:
> My main goal in asking about this was mostly to suggest not making
unnecessary changes, in order to keep the diff minimal. As long as there's a
reason to choose one over the other... whether it's "keep the diff minimal",
"follow the bootstrap examples", "keep the code small", "consistency", or some
other reason. I just might ask about those reasons, but that's not necessarily
an objection.
I didn't have much of an opinion one way or another and you made some good
points about using span instead of `<i>` so I think they are fine to stay as
`<span>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
