[GitHub] [accumulo-website] DomGarguilo commented on a diff in pull request #398: Upgrade bootstrap version from 3 to 5

[via GitHub]

DomGarguilo commented on code in PR #398:
URL: https://github.com/apache/accumulo-website/pull/398#discussion_r1321798733


##########
pages/downloads.md:
##########
@@ -85,26 +85,29 @@ available in a future update to this site.
 {% for srcbin in srcbinArray %}
 {% assign lnkFile = 'accumulo-' | append: linkVers | append: '-' | append: 
srcbin | append: '.tar.gz' %}
 {% assign lnkSuffix = '/accumulo/' | append: linkVers | append: '/' | append: 
lnkFile %}
-<div class="row btn-group" style="margin-left: 20px; margin-bottom: 5px; 
display: block">
-  <div class="col btn-group">
+<div class="row" style="margin-left: 20px; margin-bottom: 5px;">
+  <div class="btn-group col-auto">
     <a {{btnDownloadStyle}} href="{{closerLink}}{{lnkSuffix}}" 
link-suffix="{{lnkSuffix}}">{{lnkFile}}{{glyphSave}}</a>
-  </div><div class="col btn-group">
-    <a {{btnSigStyle}} 
href="{{downloadsLink}}{{lnkSuffix}}.asc">ASC{{glyphLock}}</a>
-    <a {{btnHashStyle}} 
href="{{downloadsLink}}{{lnkSuffix}}.sha512">SHA{{glyphLock}}</a>
+    <div class="btn-group">
+      <a {{btnSigStyle}} 
href="{{downloadsLink}}{{lnkSuffix}}.asc">ASC{{glyphLock}}</a>
+      <a {{btnHashStyle}} 
href="{{downloadsLink}}{{lnkSuffix}}.sha512">SHA{{glyphLock}}</a>
+    </div>

Review Comment:
   Should be fixed as of 531aded.
   
   Here is a screencap with only the top one fixed to show the difference:
   ![new button 
wrap](https://github.com/apache/accumulo-website/assets/47725857/6e25343b-bddd-4335-9626-33bbc1379982)
   
   And here is a screencap with all fixed (how it appears with the commit 
above):
   ![whole page wrap 
5](https://github.com/apache/accumulo-website/assets/47725857/9bb083a9-e053-4e50-87a0-e39ac7ef657a)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org