ctubbsii commented on code in PR #398:
URL: https://github.com/apache/accumulo-website/pull/398#discussion_r1312686597
##########
_includes/nav.html:
##########
@@ -1,64 +1,62 @@
-<nav class="navbar navbar-default navbar-fixed-top">
+<nav class="navbar navbar-expand-lg navbar-light fixed-top bg-light">
<div class="container">
- <div class="navbar-header">
- <button type="button" class="navbar-toggle" data-toggle="collapse"
data-target="#navbar-items">
- <span class="sr-only">Toggle navigation</span>
- <span class="icon-bar"></span>
- <span class="icon-bar"></span>
- <span class="icon-bar"></span>
- </button>
- <a href="{{ site.baseurl }}/"><img id="nav-logo" alt="Apache Accumulo"
class="img-responsive" src="{{ site.baseurl }}/images/accumulo-logo.png"
width="200"
- /></a>
- </div>
+ <a class="navbar-brand" href="{{ site.baseurl }}/">
+ <img alt="Apache Accumulo" id="nav-logo" src="{{ site.baseurl
}}/images/accumulo-logo.png" width="200">
+ </a>
+ <button class="navbar-toggler" type="button" data-bs-toggle="collapse"
data-bs-target="#navbar-items">
+ <span class="navbar-toggler-icon"></span>
+ </button>
<div class="collapse navbar-collapse" id="navbar-items">
- <ul class="nav navbar-nav">
- <li class="nav-link"><a href="{{ site.baseurl
}}/downloads">Download</a></li>
- <li class="nav-link"><a href="{{ site.baseurl }}/tour">Tour</a></li>
- <li class="dropdown">
- <a class="dropdown-toggle" data-toggle="dropdown"
href="#">Releases<span class="caret"></span></a>
+ <ul class="navbar-nav me-auto">
+ <li class="nav-item"><a class="nav-link" href="{{ site.baseurl
}}/downloads">Download</a></li>
+ <li class="nav-item"><a class="nav-link" href="{{ site.baseurl
}}/tour">Tour</a></li>
+ <li class="nav-item dropdown">
+ <a class="nav-link dropdown-toggle" href="#" role="button"
data-bs-toggle="dropdown">Releases</a>
<ul class="dropdown-menu">
- <li><a href="{{ site.baseurl }}/release/accumulo-3.0.0/">3.0.0
(Latest non-LTM)</a></li>
- <li><a href="{{ site.baseurl }}/release/accumulo-2.1.2/">2.1.2
(Latest LTM)</a></li>
- <li><a href="{{ site.baseurl }}/release/accumulo-1.10.3/">1.10.3
(Legacy LTM)</a></li>
- <li><a href="{{ site.baseurl }}/release/">Archive</a></li>
+ <li><a class="dropdown-item" href="{{ site.baseurl
}}/release/accumulo-3.0.0/">3.0.0 (Latest non-LTM)</a></li>
+ <li><a class="dropdown-item" href="{{ site.baseurl
}}/release/accumulo-2.1.2/">2.1.2 (Latest LTM)</a></li>
+ <li><a class="dropdown-item" href="{{ site.baseurl
}}/release/accumulo-1.10.3/">1.10.3 (Legacy LTM)</a></li>
+ <li><a class="dropdown-item" href="{{ site.baseurl
}}/release/">Archive</a></li>
</ul>
</li>
- <li class="dropdown">
- <a class="dropdown-toggle" data-toggle="dropdown"
href="#">Documentation<span class="caret"></span></a>
+ <li class="nav-item dropdown">
+ <a class="nav-link dropdown-toggle" href="#" role="button"
data-bs-toggle="dropdown">Documentation</a>
<ul class="dropdown-menu">
- <li><a href="{{ site.docs_baseurl }}">User Manual (2.x)</a></li>
- <li><a href="{{ site.baseurl }}/docs/2.x/apidocs">Javadocs
(2.x)</a></li>
- <li><a href="{{ site.baseurl }}/api">Public API</a></li>
- <li><a href="{{ site.baseurl }}/quickstart-1.x">Quickstart
(1.x)</a></li>
- <li><a href="{{ site.baseurl }}/accumulo2-maven-plugin">Accumulo
Maven Plugin</a></li>
- <li><a href="{{ site.baseurl
}}/1.10/accumulo_user_manual.html">User Manual (1.10)</a></li>
- <li><a href="{{ site.baseurl }}/1.10/apidocs">Javadocs
(1.10)</a></li>
- <li><a href="{{ site.baseurl }}/external-docs">External
Docs</a></li>
- <li><a href="{{ site.baseurl }}/docs-archive/">Archive</a></li>
+ <li><a class="dropdown-item" href="{{ site.docs_baseurl }}">User
Manual (2.x)</a></li>
+ <li><a class="dropdown-item" href="{{ site.baseurl
}}/docs/2.x/apidocs">Javadocs (2.x)</a></li>
+ <li><a class="dropdown-item" href="{{ site.baseurl }}/api">Public
API</a></li>
+ <li><a class="dropdown-item" href="{{ site.baseurl
}}/quickstart-1.x">Quickstart (1.x)</a></li>
+ <li><a class="dropdown-item" href="{{ site.baseurl
}}/accumulo2-maven-plugin">Accumulo Maven Plugin</a></li>
+ <li><a class="dropdown-item" href="{{ site.baseurl
}}/1.10/accumulo_user_manual.html">User Manual (1.10)</a></li>
+ <li><a class="dropdown-item" href="{{ site.baseurl
}}/1.10/apidocs">Javadocs (1.10)</a></li>
+ <li><a class="dropdown-item" href="{{ site.baseurl
}}/external-docs">External Docs</a></li>
+ <li><a class="dropdown-item" href="{{ site.baseurl
}}/docs-archive/">Archive</a></li>
</ul>
</li>
- <li class="dropdown">
- <a class="dropdown-toggle" data-toggle="dropdown"
href="#">Community<span class="caret"></span></a>
+ <li class="nav-item dropdown">
+ <a class="nav-link dropdown-toggle" href="#" role="button"
data-bs-toggle="dropdown">Community</a>
<ul class="dropdown-menu">
- <li><a href="{{ site.baseurl }}/contact-us">Contact Us</a></li>
- <li><a href="{{ site.baseurl }}/how-to-contribute">How To
Contribute</a></li>
- <li><a href="{{ site.baseurl }}/people">People</a></li>
- <li><a href="{{ site.baseurl }}/related-projects">Related
Projects</a></li>
+ <li><a class="dropdown-item" href="{{ site.baseurl
}}/contact-us">Contact Us</a></li>
+ <li><a class="dropdown-item" href="{{ site.baseurl
}}/how-to-contribute">How To Contribute</a></li>
+ <li><a class="dropdown-item" href="{{ site.baseurl
}}/people">People</a></li>
+ <li><a class="dropdown-item" href="{{ site.baseurl
}}/related-projects">Related Projects</a></li>
</ul>
</li>
- <li class="nav-link"><a href="{{ site.baseurl
}}/search">Search</a></li>
+ <li class="nav-item"><a class="nav-link" href="{{ site.baseurl
}}/search">Search</a></li>
</ul>
- <ul class="nav navbar-nav navbar-right">
- <li class="dropdown">
- <a class="dropdown-toggle" data-toggle="dropdown" href="#"><img
alt="Apache Software Foundation"
src="https://www.apache.org/foundation/press/kit/feather.svg"; width="15"/><span
class="caret"></span></a>
+ <ul class="navbar-nav ms-auto">
+ <li class="nav-item dropdown">
+ <a class="nav-link dropdown-toggle" href="#" role="button"
data-bs-toggle="dropdown">
+ <img alt="Apache Software Foundation"
src="https://www.apache.org/foundation/press/kit/feather.svg"; width="15"/>
+ </a>
<ul class="dropdown-menu">
- <li><a href="https://www.apache.org";>Apache Homepage <i
class="fa-solid fa-up-right-from-square"></i></a></li>
- <li><a href="https://www.apache.org/licenses/";>License <i
class="fa-solid fa-up-right-from-square"></i></a></li>
- <li><a
href="https://www.apache.org/foundation/sponsorship";>Sponsorship <i
class="fa-solid fa-up-right-from-square"></i></a></li>
- <li><a href="https://www.apache.org/security";>Security <i
class="fa-solid fa-up-right-from-square"></i></a></li>
- <li><a href="https://www.apache.org/foundation/thanks";>Thanks <i
class="fa-solid fa-up-right-from-square"></i></a></li>
- <li><a
href="https://www.apache.org/foundation/policies/conduct";>Code of Conduct <i
class="fa-solid fa-up-right-from-square"></i></a></li>
- <li><a
href="https://www.apache.org/events/current-event.html";>Current Event <i
class="fa-solid fa-up-right-from-square"></i></a></li>
+ <li><a class="dropdown-item" href="https://www.apache.org";>Apache
Homepage <i class="fa-solid fa-up-right-from-square"></i></a></li>
Review Comment:
I looked at the documentation, and I'm not sure I'm right about this. I
framed it more as a question, because I wasn't sure. The documentation seems to
indicate it's primarily for the keyboard navigation, not part of the visual of
the menu. I'm still not sure why it's needed explicitly, instead of being
inferred, but I don't have much free time to play with it.
I would follow the bootstrap examples, though. The correct answer to my
previous questions probably should have been "no". Sorry if I created more
churn by asking this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
![https://www.apache.org/foundation/press/kit/feather.svg"](https://www.apache.org/foundation/press/kit/feather.svg"){kind=link}