dlmarion commented on code in PR #19: URL: https://github.com/apache/accumulo-access/pull/19#discussion_r1342634273
########## src/build/ci/find-unapproved-chars.sh: ########## @@ -0,0 +1,52 @@ +#! /usr/bin/env bash Review Comment: Should we remove this check? ########## src/build/ci/find-unapproved-junit.sh: ########## @@ -0,0 +1,55 @@ +#! /usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# https://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# The purpose of this ci script is to ensure that a pull request doesn't +# unintentionally add JUnit jupiter APIs to vintage tests, or add vintage +# APIs to new jupiter tests. +NUM_EXPECTED=0 +ALLOWED=( + server/compaction-coordinator/src/test/java/org/apache/accumulo/coordinator/CompactionCoordinatorTest.java Review Comment: I assume I should remove these and that ALLOWED should be empty. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
