dlmarion commented on code in PR #19: URL: https://github.com/apache/accumulo-access/pull/19#discussion_r1342817506
########## .github/CONTRIBUTING.md: ########## @@ -0,0 +1,41 @@ +<!-- + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + https://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +--> + +# Contributors Guide + +If you believe that you have found a [bug](https://github.com/apache/accumulo-access/labels/bug), please search for an existing [issue](https://github.com/apache/accumulo-access/issues) to see if it has already been reported. If you would like to add a new feature to Accumulo-Access, please send an email with your idea to the [dev](mailto:[email protected]) mail list. If it's appropriate, then we will create an issue. For simple changes, it's ok to just submit a pull request without an issue. + +## Development + +- See the [Developer's Guide](https://accumulo.apache.org/how-to-contribute/) for information regarding common build commands, IDE setup and more. +- Ensure that your work targets the correct branch +- Add/update unit and integration tests + +## Patch Submission + +- Ensure that Accumulo-Access builds cleanly before submitting your patch using the command: `mvn clean verify -DskipITs` Review Comment: Fixed in 14b1c0d ########## .github/workflows/maven.yaml: ########## @@ -0,0 +1,133 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# https://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# This workflow will build a Java project with Maven +# See also: +# https://help.github.com/actions/language-and-framework-guides/building-and-testing-java-with-maven + +name: QA + +on: + push: + branches: [ '*' ] + pull_request: + branches: [ '*' ] + +permissions: + contents: read + +jobs: + # fast build to populate the local maven repository cache + fastbuild: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - name: Set up JDK 11 + uses: actions/setup-java@v3 + with: + distribution: adopt + java-version: 11 + - name: Cache local maven repository + uses: actions/cache@v3 + with: + path: | + ~/.m2/repository/ + !~/.m2/repository/org/apache/accumulo + key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }} + restore-keys: ${{ runner.os }}-m2 + - name: Show the first log message + run: git log -n1 + - name: Check for unapproved characters + run: src/build/ci/find-unapproved-chars.sh + - name: Check for unapproved JUnit API usage + run: src/build/ci/find-unapproved-junit.sh + - name: Build with Maven (Fast Build) + timeout-minutes: 20 + run: mvn -B -V -e -ntp "-Dstyle.color=always" clean package dependency:resolve -DskipTests -DskipFormat -DverifyFormat + env: + MAVEN_OPTS: -Djansi.force=true + # more complete builds with tests + mvn: + needs: fastbuild + strategy: + matrix: + profile: + - {name: 'unit-tests', javaver: 11, args: 'verify -PskipQA -DskipTests=false'} Review Comment: Fixed in 14b1c0d -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
