dlmarion commented on code in PR #19:
URL: https://github.com/apache/accumulo-access/pull/19#discussion_r1342817789
##########
pom.xml:
##########
@@ -159,4 +191,240 @@
</plugin>
</plugins>
</build>
+ <profiles>
+ <profile>
+ <!-- This profile skips all Quality Assurance checks; activate with
-PskipQA OR -DskipQA -->
+ <id>skipQA</id>
+ <activation>
+ <property>
+ <name>skipQA</name>
+ </property>
+ </activation>
+ <properties>
+ <accumulo.skip>true</accumulo.skip>
+ <apilyzer.skip>true</apilyzer.skip>
+ <checkstyle.skip>true</checkstyle.skip>
+ <formatter.skip>true</formatter.skip>
+ <impsort.skip>true</impsort.skip>
+ <mdep.analyze.skip>true</mdep.analyze.skip>
+ <modernizer.skip>true</modernizer.skip>
+ <rat.skip>true</rat.skip>
+ <skipITs>true</skipITs>
+ <skipTests>true</skipTests>
+ <sort.skip>true</sort.skip>
+ <spotbugs.skip>true</spotbugs.skip>
+ <warbucks.skip>true</warbucks.skip>
+ </properties>
+ </profile>
+ <profile>
+ <!-- off by default, but enable with '-P verifyformat' or
'-DverifyFormat' -->
+ <id>verifyformat</id>
+ <activation>
+ <property>
+ <name>verifyFormat</name>
+ </property>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>com.github.ekryd.sortpom</groupId>
+ <artifactId>sortpom-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>verify-sorted-pom</id>
+ <goals>
+ <goal>verify</goal>
+ </goals>
+ <phase>process-resources</phase>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>com.mycila</groupId>
+ <artifactId>license-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>verify-license-headers</id>
+ <goals>
+ <goal>check</goal>
+ </goals>
+ <phase>process-test-resources</phase>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>net.revelc.code.formatter</groupId>
+ <artifactId>formatter-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>verify-formatted-java-source</id>
+ <goals>
+ <goal>validate</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>net.revelc.code</groupId>
+ <artifactId>impsort-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>verify-sorted-imports</id>
+ <goals>
+ <goal>check</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
+ <profile>
+ <!-- on by default, but disable with '-P !autoformat' or '-DskipFormat'
-->
+ <id>autoformat</id>
+ <activation>
+ <property>
+ <name>!skipFormat</name>
+ </property>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>com.github.ekryd.sortpom</groupId>
+ <artifactId>sortpom-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>sort-pom</id>
+ <goals>
+ <goal>sort</goal>
+ </goals>
+ <phase>process-sources</phase>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>com.mycila</groupId>
+ <artifactId>license-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>license-headers</id>
+ <goals>
+ <goal>format</goal>
+ </goals>
+ <phase>process-test-resources</phase>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>net.revelc.code.formatter</groupId>
+ <artifactId>formatter-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>format-java-source</id>
+ <goals>
+ <goal>format</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>net.revelc.code</groupId>
+ <artifactId>impsort-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>sort-imports</id>
+ <goals>
+ <goal>sort</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
+ <profile>
+ <id>sec-bugs</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>com.github.spotbugs</groupId>
+ <artifactId>spotbugs-maven-plugin</artifactId>
+ <configuration>
+ <plugins>
+ <plugin>
+ <groupId>com.h3xstream.findsecbugs</groupId>
+ <artifactId>findsecbugs-plugin</artifactId>
+ <version>1.12.0</version>
+ </plugin>
+ </plugins>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
+ <profile>
+ <!-- This profile uses the Google ErrorProne tool to perform static code
analysis at
+ compile time. Auto-generated code is not checked.
+ See: https://errorprone.info/bugpatterns for list of available bug
patterns.-->
+ <id>errorprone</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <configuration>
+ <compilerArgs>
+ <arg>-XDcompilePolicy=simple</arg>
+ <arg>
+ -Xplugin:ErrorProne \
+ -XepExcludedPaths:.*/(thrift|generated-sources|src/test)/.* \
Review Comment:
Fixed in 14b1c0d
##########
src/build/ci/find-unapproved-chars.sh:
##########
@@ -0,0 +1,52 @@
+#! /usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+# The purpose of this ci script is to ensure that a pull request doesn't
+# unintentionally, or maliciously, add any new non-ASCII characters unless they
+# are preapproved on the ALLOWED list or in known binary or resource files
+NUM_EXPECTED=0
+ALLOWED='©èö🐈三四五六八九十'
+
+function findallnonascii() {
+ # -P for perl matching, -o for only showing the match for counting
occurrences not lines
+ local opts='-Po'
+ if [[ $1 == 'print' ]]; then
+ # -P for perl matching, -H for always showing filenames, -n for showing
line numbers
+ opts='-PHn'
+ fi
+ find . -type f \
+ -not -path '*/\.git/*' \
+ -not -path '*/monitor/resources/external/*' \
+ -not -path '*/tserver/src/test/resources/walog-from-14/*' \
Review Comment:
Fixed in 14b1c0d
##########
src/build/ci/find-unapproved-chars.sh:
##########
@@ -0,0 +1,52 @@
+#! /usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+# The purpose of this ci script is to ensure that a pull request doesn't
+# unintentionally, or maliciously, add any new non-ASCII characters unless they
+# are preapproved on the ALLOWED list or in known binary or resource files
+NUM_EXPECTED=0
+ALLOWED='©èö🐈三四五六八九十'
+
+function findallnonascii() {
+ # -P for perl matching, -o for only showing the match for counting
occurrences not lines
+ local opts='-Po'
+ if [[ $1 == 'print' ]]; then
+ # -P for perl matching, -H for always showing filenames, -n for showing
line numbers
+ opts='-PHn'
+ fi
+ find . -type f \
+ -not -path '*/\.git/*' \
+ -not -path '*/monitor/resources/external/*' \
+ -not -path '*/tserver/src/test/resources/walog-from-14/*' \
+ -not -regex '.*[.]\(png\|jar\|rf\|jceks\|walog\)$' \
Review Comment:
Fixed in 14b1c0d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
