DomGarguilo commented on code in PR #3817:
URL: https://github.com/apache/accumulo/pull/3817#discussion_r1347941978
##########
pom.xml:
##########
@@ -981,8 +954,6 @@
<unused>org.apache.logging.log4j:log4j-1.2-api:jar:*</unused>
<unused>org.apache.logging.log4j:log4j-slf4j2-impl:jar:*</unused>
<unused>org.apache.logging.log4j:log4j-web:jar:*</unused>
- <!-- This should be removed upon completion of migrating junit
4 to 5 -->
- <unused>org.junit.vintage:junit-vintage-engine:jar:*</unused>
Review Comment:
Additionally in the pom, in the `maven-checkstyle-plugin` section, we might
be able to remove some rules that refference junit4 imports or add one/some
that ensure only junit jupiter imports are used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
