keith-turner commented on code in PR #3817: URL: https://github.com/apache/accumulo/pull/3817#discussion_r1348023311
########## pom.xml: ########## @@ -981,8 +954,6 @@ <unused>org.apache.logging.log4j:log4j-1.2-api:jar:*</unused> <unused>org.apache.logging.log4j:log4j-slf4j2-impl:jar:*</unused> <unused>org.apache.logging.log4j:log4j-web:jar:*</unused> - <!-- This should be removed upon completion of migrating junit 4 to 5 --> - <unused>org.junit.vintage:junit-vintage-engine:jar:*</unused> Review Comment: So removing powermock mean we can remove usage of all old junit apis? If so that is nice, it would be nice if the old stuff was no longer there in autocomplete in IDE. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org