dlmarion commented on code in PR #3817:
URL: https://github.com/apache/accumulo/pull/3817#discussion_r1349227858
##########
src/build/ci/find-unapproved-junit.sh:
##########
@@ -38,8 +36,10 @@ function findalljunitproblems() {
fi
# find any new classes using something other than the jupiter API, except
those allowed
grep "$opts" --include='*.java' 'org[.]junit[.](?!jupiter)' | grep -Pv
"^(${ALLOWED_PIPE_SEP//./[.]})\$"
- # find any uses of the jupiter API in the allowed vintage classes
- grep "$opts" 'org[.]junit[.]jupiter' "${ALLOWED[@]}"
+ if ((${#ALLOWED[@]} != 0)); then
Review Comment:
I left it there just in case we needed it in the future for some reason. We
have the same thing in accumulo-access with this script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
