DomGarguilo commented on code in PR #27:
URL: https://github.com/apache/accumulo-access/pull/27#discussion_r1372250444
##########
src/main/java/org/apache/accumulo/access/AccessExpressionImpl.java:
##########
@@ -34,11 +34,6 @@ class AccessExpressionImpl implements AccessExpression {
@Override
public String getExpression() {
- var expStr = expressionString.get();
- if (expStr != null) {
- return expStr;
- }
-
return expressionString.updateAndGet(es -> es == null ? new
String(expression, UTF_8) : es);
Review Comment:
I guess both checks for null are needed in case the value changes between
the first and second readings of `expressionString`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
