dlmarion commented on code in PR #27:
URL: https://github.com/apache/accumulo-access/pull/27#discussion_r1373275878
##########
src/main/java/org/apache/accumulo/access/AccessEvaluatorImpl.java:
##########
@@ -230,4 +226,8 @@ public AccessEvaluator build() {
public static AuthorizationsBuilder builder() {
return new BuilderImpl();
}
+
+ private static boolean isQuoteOrSlash(byte b) {
Review Comment:
I think this implementation might perform better. For each invocation of the
current method, the input argument `b` has to go through a conversion from
`byte` to `char` as described
[here](https://docs.oracle.com/javase/specs/jls/se11/html/jls-5.html#jls-5.1.4).
```
private static final byte QUOTE = (byte) '"';
private static final byte BACKSLASH = (byte) '\\';
private static boolean isQuoteOrSlash(byte b) {
return b == quote || b == backslash;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
