dlmarion commented on code in PR #27:
URL: https://github.com/apache/accumulo-access/pull/27#discussion_r1373411607
##########
src/main/java/org/apache/accumulo/access/AeNode.java:
##########
@@ -200,7 +203,7 @@ private AndNode(List<AeNode> children) {
@Override
char operator() {
- return '&';
+ return AND_OPERATOR;
Review Comment:
This method returns a `char`, so I think we want to leave it unless from
where it's called its being cast to a `byte`.
##########
src/main/java/org/apache/accumulo/access/AeNode.java:
##########
@@ -249,7 +252,7 @@ private OrNode(List<AeNode> children) {
@Override
char operator() {
- return '|';
+ return OR_OPERATOR;
Review Comment:
This method returns a `char`, so I think we want to leave it unless from
where it's called its being cast to a `byte`.
##########
src/main/java/org/apache/accumulo/access/AeNode.java:
##########
@@ -300,9 +303,9 @@ static AeNode of(Tokenizer.AuthorizationToken auth) {
static AeNode of(byte operator, List<AeNode> children) {
switch (operator) {
- case '&':
+ case AND_OPERATOR:
Review Comment:
These are comparing bytes, so they are good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
