DomGarguilo commented on code in PR #4208:
URL: https://github.com/apache/accumulo/pull/4208#discussion_r1474978105
##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/tableImport/PopulateMetadataTable.java:
##########
@@ -176,6 +183,12 @@ public Repo<Manager> call(long tid, Manager manager)
throws Exception {
sawHostingGoal = false;
}
+ if (initialHostingGoal != null) {
+ // add the initial hosting goal
+ HostingColumnFamily.GOAL_COLUMN.put(m,
+ TabletHostingGoalUtil.toValue(initialHostingGoal));
+ sawHostingGoal = true;
+ }
Review Comment:
Not necessarily. It is a bit confusing but this code checks if
initialHostingGoal was provided and if so it sets it. Then it checks if
something is set in the column. The way the code is now, the initialHostingGoal
does not have to be provided so if it is null, the check still needs to happen
if there is a hosting goal already set in the column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
