EdColeman commented on code in PR #4208:
URL: https://github.com/apache/accumulo/pull/4208#discussion_r1476713971
##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/tableImport/PopulateMetadataTable.java:
##########
@@ -155,11 +166,7 @@ public Repo<Manager> call(long tid, Manager manager)
throws Exception {
if (m == null || !currentRow.equals(metadataRow)) {
if (m != null) {
- if (!sawTabletAvailability) {
- // add a default tablet availability
- TabletColumnFamily.AVAILABILITY_COLUMN.put(m,
-
TabletAvailabilityUtil.toValue(TabletAvailability.ONDEMAND));
- }
+ AVAILABILITY_COLUMN.put(m,
TabletAvailabilityUtil.toValue(initialAvailability));
Review Comment:
It may be just requiring the goal on import and ignoring (or never
persisting) the goal on export would be the "least surprising" to users. Maybe
the import could default to unhosted. The user should know at import the
desired availability state. That could have no relationship to what it was
when it was exported.
If we do allow the export to define the availability, then maybe we need a
way to allow that state to be examined? Basically, other than a manual
process, how would a user know and track how a table was exported? Does it
really matter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
