dlmarion commented on code in PR #4208:
URL: https://github.com/apache/accumulo/pull/4208#discussion_r1476517305


##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/tableImport/PopulateMetadataTable.java:
##########
@@ -155,11 +166,7 @@ public Repo<Manager> call(long tid, Manager manager) 
throws Exception {
             if (m == null || !currentRow.equals(metadataRow)) {
 
               if (m != null) {
-                if (!sawTabletAvailability) {
-                  // add a default tablet availability
-                  TabletColumnFamily.AVAILABILITY_COLUMN.put(m,
-                      
TabletAvailabilityUtil.toValue(TabletAvailability.ONDEMAND));
-                }
+                AVAILABILITY_COLUMN.put(m, 
TabletAvailabilityUtil.toValue(initialAvailability));

Review Comment:
   > Now it always overwrites the tablet availability and does not consider if 
the imported tablets already had availability set.
   
   I had a simiilar thought when reviewing the code. I figured that because 
this was import table, that it was creating a new table, not importing files 
into an existing table or tablets. Am I wrong here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to