keith-turner commented on code in PR #4208:
URL: https://github.com/apache/accumulo/pull/4208#discussion_r1476738203
##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/tableImport/PopulateMetadataTable.java:
##########
@@ -155,11 +166,7 @@ public Repo<Manager> call(long tid, Manager manager)
throws Exception {
if (m == null || !currentRow.equals(metadataRow)) {
if (m != null) {
- if (!sawTabletAvailability) {
- // add a default tablet availability
- TabletColumnFamily.AVAILABILITY_COLUMN.put(m,
-
TabletAvailabilityUtil.toValue(TabletAvailability.ONDEMAND));
- }
+ AVAILABILITY_COLUMN.put(m,
TabletAvailabilityUtil.toValue(initialAvailability));
Review Comment:
> Basically, other than a manual process, how would a user know and track
how a table was exported? Does it really matter?
Export/import table will transfer tablet metadata like split and tablet
configuration in addition to the tables data. Transferring the tablet
availability a user set feels consistent with this existing functionality of
transferring table metadata.
As for inspecting a table, the current API allows importing a table and
having its initial state be offline. Could extend what @dlmarion proposed to
be following.
1. Export the tablet availability
2. Import the tablet availability AND set the initial table state to offline
3. Have the user use the shell command to change it the way that they want
it
4. Online table
Not sure if we can set table availability when a table is offline though, if
not then step 3 above would not work. Was thinking that adding the extra step
of offline helps avoid unwanted tablet hosting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
