keith-turner commented on code in PR #4244:
URL: https://github.com/apache/accumulo/pull/4244#discussion_r1483264730
##########
core/src/main/java/org/apache/accumulo/core/metrics/MetricsUtil.java:
##########
@@ -105,14 +108,16 @@ public DistributionStatisticConfig configure(Meter.Id id,
}
};
- Class<? extends MeterRegistryFactory> clazz =
- ClassLoaderUtil.loadClass(factoryClass, MeterRegistryFactory.class);
- MeterRegistryFactory factory =
clazz.getDeclaredConstructor().newInstance();
+ for (String factoryName : getTrimmedStrings(factoryClasses)) {
+ Class<? extends MeterRegistryFactory> clazz =
+ ClassLoaderUtil.loadClass(factoryName, MeterRegistryFactory.class);
Review Comment:
If someone had the old Factory interface configured it seems like this would
blow up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
