keith-turner commented on code in PR #4244:
URL: https://github.com/apache/accumulo/pull/4244#discussion_r1483266070
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -300,8 +300,11 @@ public enum Property {
"Enables metrics functionality using Micrometer.", "2.1.0"),
GENERAL_MICROMETER_JVM_METRICS_ENABLED("general.micrometer.jvm.metrics.enabled",
"false",
PropertyType.BOOLEAN, "Enables JVM metrics functionality using
Micrometer.", "2.1.0"),
- GENERAL_MICROMETER_FACTORY("general.micrometer.factory", "",
PropertyType.CLASSNAME,
- "Name of class that implements MeterRegistryFactory.", "2.1.0"),
+ GENERAL_MICROMETER_FACTORY("general.micrometer.factory",
+ "org.apache.accumulo.core.spi.metrics.SimpleLoggingMeterRegistryFactory",
+ PropertyType.CLASSNAMELIST,
+ "A comma separated list of one or more class names that implement
MeterRegistryFactory.",
Review Comment:
It would be good to explain the change in expected interface class in the
docs and what the support for the old interface class is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
