keith-turner commented on code in PR #4244: URL: https://github.com/apache/accumulo/pull/4244#discussion_r1483291797
########## core/src/main/java/org/apache/accumulo/core/spi/metrics/SimpleLoggingMeterRegistryFactory.java: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.core.spi.metrics; + +import java.util.function.Consumer; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import io.micrometer.core.instrument.MeterRegistry; +import io.micrometer.core.instrument.logging.LoggingMeterRegistry; +import io.micrometer.core.instrument.logging.LoggingRegistryConfig; + +/** + * Example implementation of enabling a metrics provider by implementing the + * {@link org.apache.accumulo.core.spi.metrics.MeterRegistryFactory} interface. When enabled though + * properties by enabling {@code Property.GENERAL_MICROMETER_ENABLED} and providing this class for + * the {@code Property.GENERAL_MICROMETER_FACTORY} + * <p> + * The metrics will appear in the normal service logs with a named logger of + * {@code org.apache.accumulo.METRICS} at the INFO level. The metrics output can be directed to a + * file using standard logging configuration properties. + */ +public class SimpleLoggingMeterRegistryFactory implements MeterRegistryFactory { + + private static final Logger LOG = + LoggerFactory.getLogger(SimpleLoggingMeterRegistryFactory.class); + + // named logger that can be configured using standard logging properties. + private static final Logger METRICS = LoggerFactory.getLogger("org.apache.accumulo.METRICS"); + + private final Consumer<String> metricConsumer = METRICS::info; + + // defines the metrics update period, default is 60 seconds. + private final LoggingRegistryConfig lconf = c -> { + if (c.equals("logging.step")) { + return "60s"; Review Comment: The config problem is not something to worry about this in PR as its a per-existing pattern. I am just wondering how someone would use actually use this feature and it it requires recompiling java code for every metrics config change. If the end to end user experience could be improved we could consider that when introducing a new interface though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
