EdColeman commented on code in PR #4572:
URL: https://github.com/apache/accumulo/pull/4572#discussion_r1612385132
##########
server/compactor/src/main/java/org/apache/accumulo/compactor/Compactor.java:
##########
@@ -159,6 +160,15 @@ protected Compactor(CompactorServerOpts opts, String[]
args) {
@Override
public void registerMetrics(MeterRegistry registry) {
+
+ // TODO Should the metrics have the same name in both processes?
+ FunctionCounter
+ .builder(METRICS_COMPACTOR_ENTRIES_READ, null, o ->
FileCompactor.getTotalEntriesRead())
+ .description("Number of entries read").tag("type",
"compactor").register(registry);
Review Comment:
I don't think type=compactor is a common tag - it may be being added as a
custom tag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
