keith-turner commented on code in PR #4572:
URL: https://github.com/apache/accumulo/pull/4572#discussion_r1612397539
##########
server/compactor/src/main/java/org/apache/accumulo/compactor/Compactor.java:
##########
@@ -159,6 +160,15 @@ protected Compactor(CompactorServerOpts opts, String[]
args) {
@Override
public void registerMetrics(MeterRegistry registry) {
+
+ // TODO Should the metrics have the same name in both processes?
+ FunctionCounter
+ .builder(METRICS_COMPACTOR_ENTRIES_READ, null, o ->
FileCompactor.getTotalEntriesRead())
+ .description("Number of entries read").tag("type",
"compactor").register(registry);
Review Comment:
> I don't think type=compactor is a common tag - it may be being added as a
custom tag.
Yeah I don't think its a common tag. Was thinking that `process.name`
provides the same info and therefore may not need to add the type tag.
Found the 2.1 code that adds the `process.name` tag. So I think the type tag
could be dropped here as its redundant w/ `process.name`
https://github.com/apache/accumulo/blob/b21837a39e51968b8cc87dcf9781fa37b5aefd39/server/base/src/main/java/org/apache/accumulo/server/metrics/MetricsInfoImpl.java#L119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
