DomGarguilo commented on PR #4572:
URL: https://github.com/apache/accumulo/pull/4572#issuecomment-2135994058

   
   
   
   > > I tried merging your branch into this one but I haven't been able to see 
these metrics. The new IT that I added was picking them up before but I am not 
seeing them at all now. Still looking into why that might be.
   > 
   > @DomGarguilo just saw this comment, missed it earlier when I reviewed. I 
can take at a look at this.
   
   In dfec4a1 I made wrapper methods in `Compactor` for 
`FileCompactor.getTotalEntriesWritten()` and 
`FileCompactor.getTotalEntriesRead()` so that when setting up the 
`FunctionCounter`, we can use `this` instead of `null` as the object that is 
used. This seemed to fix the issue I was seeing where I couldnt see the 
metrics. Not sure if using `null` as the object caused the issue but thats my 
best guess currently. The tests passes now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to