meatballspaghetti commented on code in PR #4791:
URL: https://github.com/apache/accumulo/pull/4791#discussion_r1714365194
##########
core/src/test/java/org/apache/accumulo/core/data/KeyTest.java:
##########
@@ -39,10 +40,14 @@ public class KeyTest {
@Test
public void testDeletedCompare() {
- Key k1 = new Key("r1".getBytes(), "cf".getBytes(), "cq".getBytes(), new
byte[0], 0, false);
- Key k2 = new Key("r1".getBytes(), "cf".getBytes(), "cq".getBytes(), new
byte[0], 0, false);
- Key k3 = new Key("r1".getBytes(), "cf".getBytes(), "cq".getBytes(), new
byte[0], 0, true);
- Key k4 = new Key("r1".getBytes(), "cf".getBytes(), "cq".getBytes(), new
byte[0], 0, true);
+ Key k1 = new Key("r1".getBytes(UTF_8), "cf".getBytes(UTF_8),
"cq".getBytes(UTF_8), new byte[0],
Review Comment:
There are assertEquals statements a couple lines below to confirm that each
pair of identical Key objects are indeed identical (they are not used outside
of this particular unit test). If I reduce these four variables to two, those
assertEquals statements would no longer apply. Should I proceed with that and
delete the assertions, or leave all as is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
