DomGarguilo commented on code in PR #4791:
URL: https://github.com/apache/accumulo/pull/4791#discussion_r1715414105
##########
core/src/test/java/org/apache/accumulo/core/data/KeyTest.java:
##########
@@ -39,10 +40,14 @@ public class KeyTest {
@Test
public void testDeletedCompare() {
- Key k1 = new Key("r1".getBytes(), "cf".getBytes(), "cq".getBytes(), new
byte[0], 0, false);
- Key k2 = new Key("r1".getBytes(), "cf".getBytes(), "cq".getBytes(), new
byte[0], 0, false);
- Key k3 = new Key("r1".getBytes(), "cf".getBytes(), "cq".getBytes(), new
byte[0], 0, true);
- Key k4 = new Key("r1".getBytes(), "cf".getBytes(), "cq".getBytes(), new
byte[0], 0, true);
+ Key k1 = new Key("r1".getBytes(UTF_8), "cf".getBytes(UTF_8),
"cq".getBytes(UTF_8), new byte[0],
Review Comment:
Sorry I was pretty vague in my comment. I meant making new variables for the
row, cf and cq that are used to construct the four `Key`s. For example:
```java
final byte[] row = "r1".getBytes(UTF_8);
final byte[] cf = "cf".getBytes(UTF_8);
final byte[] cq = "cq".getBytes(UTF_8);
Key k2 = new Key(row, cf, cq, new byte[0], 0, false);
```
Either way I think the code is fine as is and no changes need to made unless
you want to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
