meatballspaghetti commented on PR #4791: URL: https://github.com/apache/accumulo/pull/4791#issuecomment-2291997745
> Changes look good and consistent with #3815. > > One thing that may have been missed is changing instances of the method ref equivalents: `String::new` and `String::getBytes` use UTF_8. I found instances of `String::new` that could be changed, but no instances of `String::getBytes`. Maybe I'm misunderstanding, but `String::new` just creates an empty String with no encoding involved and no conversion from bytes. Are you suggesting that I convert each instance of `String::new` to `s -> s.getBytes(UTF_8)`? Since they're just empty Strings to being with, I wasn't sure if that would be applicable here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
