keith-turner commented on PR #4807:
URL: https://github.com/apache/accumulo/pull/4807#issuecomment-2305481591
@kevinrr888 they all seems like good ways to handle the situation. In the
examples you posted it seems to come down to
1. Do we only look at the status of direct dependencies or do we analyze
transitive dependencies?
2. When a check is filtered out and its dependency failed, what should it
status be?
Personally I would go with the option that is the most straightforward to
implement an maintain. Option 1 or 3 seem like they are the most
straightforward to implement because they do not do transitive analysis. Seems
like option 3 chooses `SKIPPED_DEPENDENCY_FAILED` when its also filtered out.
I lean towards option 3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
