kevinrr888 commented on code in PR #4807:
URL: https://github.com/apache/accumulo/pull/4807#discussion_r1736519843


##########
server/base/src/main/java/org/apache/accumulo/server/util/Admin.java:
##########
@@ -114,6 +127,93 @@ static class PingCommand {
     List<String> args = new ArrayList<>();
   }
 
+  @Parameters(commandNames = "check",
+      commandDescription = "Performs checks for problems in Accumulo.")
+  public static class CheckCommand {
+    @Parameter(names = "list",
+        description = "Lists the different checks that can be run, the 
description of each check, and the other check(s) each check depends on.")
+    boolean list;
+
+    @Parameter(names = "run",
+        description = "Runs the provided check(s) (explicit list or regex 
pattern specified following '-p'), beginning with their dependencies, or all 
checks if none are provided.")
+    boolean run;
+
+    @Parameter(names = {"--name_pattern", "-p"},
+        description = "Runs all checks that match the provided regex pattern.")
+    boolean useRegex;

Review Comment:
   Yeah, this would be nicer. When I was first implementing this I wasn't sure 
how `JCommander` would handle that -- thought it might conflict with the 
existing `List<String> checks;` param since `pattern` would also be a string. 
But don't think I ever tested to see



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to