kevinrr888 commented on PR #4807:
URL: https://github.com/apache/accumulo/pull/4807#issuecomment-2313497026
Addressed review comments:
- Added `FILTERED_OUT` status for checks that are not specified to run
- When checks are specified, no longer run their dependencies first
- Switched from static maps for the fields (`CHECK_DESCRIPTION`,
`CHECK_DEPENDENCIES`, `CHECK_RUNNERS`) to instead be declared in the enum
constructor.
- This also meant refactoring `AdminCheckIT`
`AdminCheckIT` does not have many tests yet to avoid too much refactoring if
further structural changes are needed. Will add more after implementation is
approved.
Re https://github.com/apache/accumulo/pull/4807#issuecomment-2305481591: I
went with option 3 in b9f6d5d1aad556ff2d160ce526ef96cdcb5d82f8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
