dlmarion commented on code in PR #4819:
URL: https://github.com/apache/accumulo/pull/4819#discussion_r1728921052


##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java:
##########
@@ -1038,13 +1039,31 @@ synchronized void completeClose(boolean saveState, 
boolean completeClose) throws
       activeScan.interrupt();
     }
 
+    // create a copy so that it can be whittled down as client sessions are 
disabled

Review Comment:
   The call to `ScanDataSource.interrupt()` on line 1039 above sets the 
interrupt flag on the iterators to true. The issue we are addressing here is 
zombie scans, where the interrupt flag is being set, but not checked in some 
user supplied iterator (#4757). I wonder if we want to capture the time that 
the interrupt flag was set to true, and wait some period of time before forcing 
the tablet to close giving scans that are behaving correctly a chance to 
succeed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to