dlmarion commented on code in PR #4819:
URL: https://github.com/apache/accumulo/pull/4819#discussion_r1733031141


##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java:
##########
@@ -1038,13 +1039,31 @@ synchronized void completeClose(boolean saveState, 
boolean completeClose) throws
       activeScan.interrupt();
     }
 
+    // create a copy so that it can be whittled down as client sessions are 
disabled
+    List<ScanDataSource> runningScans = new ArrayList<>(this.activeScans);
+
+    runningScans.removeIf(scanDataSource -> {
+      boolean disabled = scanDataSource.disableClientSession();

Review Comment:
   Isn't it possible that the scan session is disabled (reservations 
disallowed) when returning false too?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to