keith-turner commented on code in PR #4819:
URL: https://github.com/apache/accumulo/pull/4819#discussion_r1733437507
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java:
##########
@@ -1038,13 +1039,31 @@ synchronized void completeClose(boolean saveState,
boolean completeClose) throws
activeScan.interrupt();
}
+ // create a copy so that it can be whittled down as client sessions are
disabled
+ List<ScanDataSource> runningScans = new ArrayList<>(this.activeScans);
+
+ runningScans.removeIf(scanDataSource -> {
+ boolean disabled = scanDataSource.disableClientSession();
Review Comment:
Updated variable and method names in b6dd442 to better match the behavior of
the code. Also removed a level indirection (a `BooleanSupplier`) I thought I
needed to avoid passing around the SessionManager, however found it was not
needed. Removing this level indirection makes the code easier to follow along
with the better names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
