dlmarion commented on code in PR #4853:
URL: https://github.com/apache/accumulo/pull/4853#discussion_r1743592185
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -908,10 +908,18 @@ public enum Property {
TABLE_MAX_END_ROW_SIZE("table.split.endrow.size.max", "10k",
PropertyType.BYTES,
"Maximum size of end row.", "1.7.0"),
TABLE_MINC_COMPACT_IDLETIME("table.compaction.minor.idle", "5m",
PropertyType.TIMEDURATION,
- "After a tablet has been idle (no mutations) for this time period it may
have its "
- + "in-memory map flushed to disk in a minor compaction. There is no
guarantee an idle "
- + "tablet will be compacted.",
+ "When the time since the last write to a tablets in memory map exceeds
this threshold. "
Review Comment:
```suggestion
"When the time since the last write to a tablets in memory map exceeds
this threshold, then"
```
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java:
##########
@@ -698,6 +701,7 @@ public synchronized ScanFileManager
newScanFileManager(ScanDispatch scanDispatch
private final AtomicLong lastReportedSize = new AtomicLong();
private final AtomicLong lastReportedMincSize = new AtomicLong();
+ private final AtomicReference<Timer> firstReportedCommitTimer = new
AtomicReference<>(null);
Review Comment:
If I'm understanding this correctly, we are tracking the first time a write
is performed to any Tablet in the TabletServer and then flushing the in-memory
map when the threshold is crossed for any table? That's because there is only
one in-memory map that is used for mutations for all tables, right? I'm
wondering if the property should be for the tablet server, not the table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
