dlmarion commented on code in PR #4853:
URL: https://github.com/apache/accumulo/pull/4853#discussion_r1745295628


##########
server/tserver/src/main/java/org/apache/accumulo/tserver/memory/LargestFirstMemoryManager.java:
##########
@@ -145,6 +147,12 @@ protected long getMinCIdleThreshold(KeyExtent extent) {
     return mincIdleThresholds.get(tableId);
   }
 
+  protected long getMaxAge(KeyExtent extent) {
+    TableId tableId = extent.tableId();
+    return mincAgeThresholds.computeIfAbsent(tableId, tid -> 
context.getTableConfiguration(tid)

Review Comment:
   Does this make this static, it won't respond to a runtime change in the 
property value? If so, could use a Caffeine cache here with expiration.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to