keith-turner commented on code in PR #4853:
URL: https://github.com/apache/accumulo/pull/4853#discussion_r1746133906
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/memory/LargestFirstMemoryManager.java:
##########
@@ -56,6 +60,8 @@ public class LargestFirstMemoryManager {
private double compactionThreshold;
private long maxObserved;
private final HashMap<TableId,Long> mincIdleThresholds = new HashMap<>();
+ private final Cache<TableId,Long> mincAgeThresholds =
+ Caffeine.newBuilder().expireAfterWrite(5, TimeUnit.MINUTES).build();
Review Comment:
> I'm wondering if the mincIdleThresholds should be a Cache as well.
yeah it should be, I will create a 2.1 PR for that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
