dlmarion commented on code in PR #5116:
URL: https://github.com/apache/accumulo/pull/5116#discussion_r1864370559
##########
assemble/bin/accumulo-cluster:
##########
@@ -685,75 +514,36 @@ EOF
;;
restart)
parse_config
- stop_all
+ ARG_ALL=1
+ control_services stop
+ control_services kill
# Make sure the JVM has a chance to fully exit
sleep 1
- start_all
+ control_services start
;;
start)
parse_config
- start_all
+ control_services start
;;
stop)
parse_config
- stop_all
+ control_services stop
;;
kill)
parse_config
- kill_all
+ control_services kill
;;
start-here)
parse_config
- start_here
+ control_services start --local --all
Review Comment:
start-here and stop-here functions have been removed and they are now just
shortcuts. These could be removed.
##########
assemble/bin/accumulo-cluster:
##########
@@ -632,22 +467,16 @@ function main() {
accumulo_cmd="${bin}/accumulo"
SSH='ssh -qnf -o ConnectTimeout=2'
- # Copy input arguments into new array
- # removing any options
- DEBUG=0
- i=0
- declare -a program_args
- for arg in "$@"; do
- if [[ $arg == "--dry-run" ]]; then
- DEBUG=1
- else
- program_args[i++]="$arg"
- fi
- done
+ cmd="$1"
+ shift
+ parse_args "$@"
- debug "debug: ${DEBUG} args: ${program_args[*]}"
+ localhost_names=("localhost" "127.0.0.1" "$(hostname)" "$(hostname -a
2>/dev/null | head -1)" "$(hostname -s)" "$(hostname -f)")
+ read -r -a localhost_interfaces <<<"$(hostname -I)"
+ LOCAL_HOST_ADDRESSES+=("${localhost_names[@]}" "${localhost_interfaces[@]}")
+ debug "${LOCAL_HOST_ADDRESSES[*]}"
Review Comment:
We could make this conditional on some variable not existing, allowing the
user to supply their own localhost addresses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
