ctubbsii commented on code in PR #5116:
URL: https://github.com/apache/accumulo/pull/5116#discussion_r1868268767


##########
assemble/bin/accumulo-cluster:
##########
@@ -208,7 +208,11 @@ function canRunOnHost() {
     exit 1
   fi
 
-  [[ $(isLocalHost "$1") == 0 ]]
+  if isLocalHost "$1"; then
+    return 0
+  else
+    return 1
+  fi

Review Comment:
   Can't you just do:
   
   ```suggestion
     isLocalHost "$1"
   ```
   
   The return code of the function is the same as the exit code of the last 
command in the function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to