dlmarion commented on PR #5116: URL: https://github.com/apache/accumulo/pull/5116#issuecomment-2511755519
> This is a substantial rewrite. It's going to take me a bit of time to review it. But my initial question is: does this include main branch specific features, or could this also be applied to the 3.1 branch, to reduce future maintenance burden there by eliminating one difference between the branches? Before this change the `accumulo-cluster` script was sufficiently different that making changes in an earlier version and merging them up required a good amount of time to merge them up. I think merging changes to the accumulo-cluster script in main at this point is going to be a pain regardless. I don't think that moving the changes upstream are going to make it much easier because of the new features in main. At the very least, the tserver and sserver group options would need to be removed for a 3.1 version, and added back in for main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
