keith-turner commented on code in PR #5262: URL: https://github.com/apache/accumulo/pull/5262#discussion_r1917106492
########## core/src/main/java/org/apache/accumulo/core/fate/AdminUtil.java: ########## @@ -285,19 +286,19 @@ private void findLocks(ZooSession zk, final ServiceLockPath lockPath, List<String> lockedIds = zr.getChildren(lockPath.toString()); for (String id : lockedIds) { - try { - FateLockPath fLockPath = FateLock.path(lockPath + "/" + id); - List<String> lockNodes = - FateLock.validateAndSort(fLockPath, zr.getChildren(fLockPath.toString())); + List<FateLock.FateLockNode> lockNodes = + FateLock.validateAndWarn(fLockPath, zr.getChildren(fLockPath.toString())); + + lockNodes.sort(Comparator.comparingLong(ln -> ln.sequence)); Review Comment: Updated to a sorted set in 3f25ce0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org