dlmarion commented on code in PR #5262:
URL: https://github.com/apache/accumulo/pull/5262#discussion_r1920493805
##########
core/src/main/java/org/apache/accumulo/core/fate/zookeeper/FateLock.java:
##########
@@ -68,16 +74,56 @@ public FateLock(ZooReaderWriter zrw, FateLockPath path) {
this.path = requireNonNull(path);
}
+ public static class FateLockNode implements Comparable<FateLockNode> {
+ public final long sequence;
+ public final String lockData;
+
+ private FateLockNode(String nodeName) {
+ int len = nodeName.length();
+ Preconditions.checkArgument(nodeName.startsWith(PREFIX) &&
nodeName.charAt(len - 11) == '#',
+ "Illegal node name %s", nodeName);
+ sequence = Long.parseLong(nodeName.substring(len - 10));
+ lockData = nodeName.substring(PREFIX.length(), len - 11);
Review Comment:
So, while this is probably unlikely to happen, the sequential numbering can
overflow causing a negative to occur, which I think would cause a problem with
this parsing instead of splitting on `#`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
