dlmarion commented on code in PR #5262:
URL: https://github.com/apache/accumulo/pull/5262#discussion_r1928797707
##########
core/src/main/java/org/apache/accumulo/core/fate/zookeeper/FateLock.java:
##########
@@ -78,11 +78,11 @@ public static class FateLockNode implements
Comparable<FateLockNode> {
public final long sequence;
public final String lockData;
- private FateLockNode(String nodeName) {
+ FateLockNode(String nodeName) {
int len = nodeName.length();
Preconditions.checkArgument(nodeName.startsWith(PREFIX) &&
nodeName.charAt(len - 11) == '#',
"Illegal node name %s", nodeName);
Review Comment:
In the case of an overflow, the character at (len - 11) be a minus sign and
cause this to fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
