dlmarion commented on PR #5438: URL: https://github.com/apache/accumulo/pull/5438#issuecomment-2770524081
> Right, so a lot of this seems like a lot of changes that don't actually get the reliability we are aiming for. We can't trust the existence of the flag to mean anything, because it does not guarantee anything. I don't think it's about trust. I think it's a convenience for the user. When the user run `ZooZap -prepare-for-upgrade` it validates that all Fate transactions have been removed. If there are still Fate transactions, then the user has the ability to restart their cluster to let them run to completion, or to remove them. Deleting the Fate transactions pre-upgrade has always been the recommended approach, but I don't think we had anything that enforced it. In #5383, the PreUpgradeCheck code that would be run as part of the 4.0 upgrade process will just fail and leave it to the user to figure out how to delete the Fate transactions using the old version of software. If you haven't looked at #5383 yet, looking at that first might make this easier to understand. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
