ctubbsii commented on PR #5555: URL: https://github.com/apache/accumulo/pull/5555#issuecomment-2902262968
> @ctubbsii - What are your thoughts on [8d0be6d](https://github.com/apache/accumulo/commit/8d0be6d0379b252f6ebcfbf9bc06ce4108d61843)? Maybe this meets some of the expectations and can be altered to meet all. That addresses some things. However, the second execution should not be configured in the parent POM at all. It should only exist in the test module, since that's where the second execution is occurring (most modules do not need a second execution). Also, even with these changes, it will still run when specifying a subset of tests a different way (using `-Psunny`, `-Dfailsafe.groups=`, or `-Dfailsafe.excludedGroups=`, etc.), so having a profile that matches on `it.test` only is not going to be sufficient. The configuration should not be hard-coded with values, but should allow for the use of properties instead. I think a simpler approach would be rename the tests included in the suite, so they automatically get skipped by default, and the suite itself is still named ending in IT, so it gets included by default. So the suite is all-or-nothing, but not in a separate execution, but in the same normal execution where you can still specify individual tests (even if they don't follow the naming convention) by using `it.test`, and all other properties, like `groups` should work just fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
