ctubbsii commented on PR #5555:
URL: https://github.com/apache/accumulo/pull/5555#issuecomment-2902463211
On a phone call with @kevinrr888 , we discussed the following plan, that I
think will satisfy everything we want out of this.
In summary:
1. Check to see if any of the stop minicluster steps need to be backported
to 2.1 to prevent leftover processes running in the background of 2.1 builds
2. Strip out the profile changes in this PR, just to minimize the changes
needed for this PR, and merge it with the various javadoc, typo, and other
small fixes
3. Create a new PR to do the following things:
a. Revert the changes to the POM for the failsafe plugin to prior to #5536
(so, no second execution or extra config for the suite test), keeping the use
of the new dependencies for the suite
b. Rename the SimpleSharedMacTestSuite to SimpleSharedMacTestSuiteIT so it
gets picked up by the normal execution of the ITs
c. Rename the ITs included in the suite so end with ITsimpleSuite (or
similar) and use that name pattern for the suite
d. Remove the new tag off all the ITs included in the suite, since those
aren't needed anymore
I think this gets us everything we want, such as:
* By default, everything in the suite will run in the normal build
* No messy POM changes that make it hard to override plugin properties on
the command-line to execute a specific test
* Executing a specific IT can still be done with `-Dit.test=` to execute a
test inside the suite (since the name, when specifying it explicitly, does not
need to match the normal pattern)
* The suite itself can be run by itself, or excluded, with a pattern that
includes or excludes SimpleSharedMacTestSuiteIT
I also think that if this works out well, that we could do something similar
with ComprehensiveIT, so it doesn't need to be all contained in the same file,
but could be split up for organizational purposes, and ComprehensiveIT could be
a suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
