kevinrr888 opened a new pull request, #5555: URL: https://github.com/apache/accumulo/pull/5555
Brief background: #5536 added a suite to run many of the SharedMiniClusterBase ITs against a single, shared cluster. The test suite currently includes the ITs which do not set a custom config prior to start up (i.e., those that call `SharedMiniClusterBase.startMiniCluster()`). This PR was originally going to add the shared mini ITs which set a custom config to the new test suite (i.e., those that call `SharedMiniClusterBase.startMiniClusterWithConfig()`). However, almost all of the tests which start with a config (except for ~5) change something about server configuration which is needed *before* starting the servers (e.g., setting the number of servers, setting max memory, changing the class used for the server, etc.). I could not come up with a way to include these in the suite without adding complexity to the ITs (e.g., need to keep track of what servers are configured differently from standard, how many "extra" servers are created, etc.). On top of that, we would still need to restart affected servers after the IT completes. I felt this complexity and the fact restarts were still needed, it was not worth trying to add these to the suite. So, this PR just adds some trivial improvements that I made when working on this: - Several ITs were not calling `stopMiniCluster()`. All tests which start a mini cluster now stop the mini cluster as well. - Added some javadoc changes - Misc. other minor changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
