kevinrr888 commented on code in PR #5547:
URL: https://github.com/apache/accumulo/pull/5547#discussion_r2116126805


##########
core/src/test/java/org/apache/accumulo/core/classloader/ContextClassLoaderFactoryTest.java:
##########
@@ -39,27 +40,33 @@
 public class ContextClassLoaderFactoryTest extends WithTestNames {
 
   @TempDir
-  private static File tempFolder;
+  private static Path tempFolder;
 
-  private String uri1;
-  private String uri2;
+  private URL uri1;
+  private URL uri2;

Review Comment:
   This is a test so doesn't really matter but could these be URI instead of 
URL since it seems they are converted to URI then to URL



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to