Re: [PR] Simplify conversions from java.nio.file.Path to File [accumulo]

[via GitHub]

kevinrr888 commented on code in PR #5547:
URL: https://github.com/apache/accumulo/pull/5547#discussion_r2116653763


##########
server/tserver/src/test/java/org/apache/accumulo/tserver/log/TestUpgradePathForWALogs.java:
##########
@@ -64,21 +63,22 @@ public class TestUpgradePathForWALogs extends WithTestNames 
{
   private TabletServer server;
 
   @TempDir
-  private static File tempDir;
+  private static java.nio.file.Path tempDir;
 
-  private static File perTestTempSubDir;
+  private static java.nio.file.Path perTestTempSubDir;
 
   @BeforeEach
   public void setUp() throws Exception {
     context = createMock(ServerContext.class);
     server = createMock(TabletServer.class);
 
     // Create a new subdirectory for each test
-    perTestTempSubDir = tempDir.toPath().resolve(testName()).toFile();
-    assertTrue(perTestTempSubDir.isDirectory() || perTestTempSubDir.mkdir(),
-        "Failed to create folder: " + perTestTempSubDir);
+    perTestTempSubDir = tempDir.resolve(testName());
+    if (!Files.isDirectory(perTestTempSubDir)) {
+      Files.createDirectories(perTestTempSubDir);
+    }

Review Comment:
   would be good to keep similar assertion: `assertTrue(Files.isDirectory(dir))`



##########
test/src/main/java/org/apache/accumulo/harness/TestingKdc.java:
##########
@@ -52,48 +54,54 @@ public class TestingKdc {
   public final String ORG_NAME = "EXAMPLE", ORG_DOMAIN = "COM";
 
   private String hostname;
-  private File keytabDir;
+  private Path keytabDir;
   private boolean started = false;
 
   public TestingKdc() throws Exception {
     this(computeKdcDir(), computeKeytabDir(), MAX_TICKET_LIFETIME_MILLIS);
   }
 
-  public static File computeKdcDir() {
+  public static Path computeKdcDir() throws IOException {
     Path userDir = Path.of(System.getProperty("user.dir"));
-    File targetDir = userDir.resolve("target").toFile();
-    if (!targetDir.exists()) {
-      assertTrue(targetDir.mkdirs());
+    Path targetDir = userDir.resolve("target");
+    if (!Files.exists(targetDir)) {
+      Files.createDirectories(targetDir);
     }
-    assertTrue(targetDir.isDirectory(), "Could not find Maven target 
directory: " + targetDir);
+    assertTrue(Files.isDirectory(targetDir), "Could not find Maven target 
directory: " + targetDir);
 
     // Create the directories: target/kerberos/minikdc
-    File kdcDir = 
targetDir.toPath().resolve("kerberos").resolve("minikdc").toFile();
+    Path kdcDir = targetDir.resolve("kerberos").resolve("minikdc");
 
-    assertTrue(kdcDir.mkdirs() || kdcDir.isDirectory());
+    if (!Files.isDirectory(kdcDir)) {
+      Files.createDirectories(kdcDir);
+    }

Review Comment:
   could add similar assertion: `assertTrue(Files.isDirectory(dir))`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org