Re: [PR] Simplify conversions from java.nio.file.Path to File [accumulo]

[via GitHub]

kevinrr888 commented on code in PR #5547:
URL: https://github.com/apache/accumulo/pull/5547#discussion_r2116694598


##########
test/src/main/java/org/apache/accumulo/harness/TestingKdc.java:
##########
@@ -52,48 +54,54 @@ public class TestingKdc {
   public final String ORG_NAME = "EXAMPLE", ORG_DOMAIN = "COM";
 
   private String hostname;
-  private File keytabDir;
+  private Path keytabDir;
   private boolean started = false;
 
   public TestingKdc() throws Exception {
     this(computeKdcDir(), computeKeytabDir(), MAX_TICKET_LIFETIME_MILLIS);
   }
 
-  public static File computeKdcDir() {
+  public static Path computeKdcDir() throws IOException {
     Path userDir = Path.of(System.getProperty("user.dir"));
-    File targetDir = userDir.resolve("target").toFile();
-    if (!targetDir.exists()) {
-      assertTrue(targetDir.mkdirs());
+    Path targetDir = userDir.resolve("target");
+    if (!Files.exists(targetDir)) {
+      Files.createDirectories(targetDir);
     }
-    assertTrue(targetDir.isDirectory(), "Could not find Maven target 
directory: " + targetDir);
+    assertTrue(Files.isDirectory(targetDir), "Could not find Maven target 
directory: " + targetDir);
 
     // Create the directories: target/kerberos/minikdc
-    File kdcDir = 
targetDir.toPath().resolve("kerberos").resolve("minikdc").toFile();
+    Path kdcDir = targetDir.resolve("kerberos").resolve("minikdc");
 
-    assertTrue(kdcDir.mkdirs() || kdcDir.isDirectory());
+    if (!Files.isDirectory(kdcDir)) {
+      Files.createDirectories(kdcDir);
+    }
 
     return kdcDir;
   }
 
-  public static File computeKeytabDir() {
+  public static Path computeKeytabDir() throws IOException {
     Path userDir = Path.of(System.getProperty("user.dir"));
-    File targetDir = userDir.resolve("target").toFile();
-    assertTrue(targetDir.exists() && targetDir.isDirectory(),
-        "Could not find Maven target directory: " + targetDir);
+    Path targetDir = userDir.resolve("target");
+    if (!Files.exists(targetDir)) {
+      Files.createDirectories(targetDir);
+    }
+    assertTrue(Files.isDirectory(targetDir), "Could not find Maven target 
directory: " + targetDir);
 
     // Create the directories: target/kerberos/keytabs
-    File keytabDir = 
targetDir.toPath().resolve("kerberos").resolve("keytabs").toFile();
+    Path keytabDir = targetDir.resolve("kerberos").resolve("keytabs");
 
-    assertTrue(keytabDir.mkdirs() || keytabDir.isDirectory());
+    if (!Files.isDirectory(keytabDir)) {
+      Files.createDirectories(keytabDir);
+    }

Review Comment:
   could add similar assertion: `assertTrue(Files.isDirectory(dir))`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org